Skip to content

Commit 618ef57

Browse files
committed
clean up spurious changes and todos with no action needed
1 parent 895be02 commit 618ef57

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

components/script/dom/eventtarget.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -526,8 +526,9 @@ impl EventTarget {
526526
let args = if is_error { ERROR_ARG_NAMES } else { ARG_NAMES };
527527

528528
let cx = window.get_cx();
529-
let options =
530-
unsafe { CompileOptionsWrapper::new(*cx, handler.url.as_str(), handler.line as u32) };
529+
let options = unsafe {
530+
CompileOptionsWrapper::new(*cx, &handler.url.to_string(), handler.line as u32)
531+
};
531532

532533
// Step 3.9, subsection Scope steps 1-6
533534
let scopechain = RootedObjectVectorWrapper::new(*cx);

components/script/dom/window.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1432,9 +1432,6 @@ impl WindowMethods for Window {
14321432
.filter(|elem| is_named_element_with_id_attribute(elem));
14331433

14341434
// Step 2.
1435-
// TODO(pylbrecht): it would be great to just iterate over
1436-
// elements_with_id, but it seems document.get_elements_with_id()
1437-
// does not return HTMLIFrameElements. Why is that?
14381435
for elem in iframe_iter.clone() {
14391436
if let Some(nested_window_proxy) = elem
14401437
.downcast::<HTMLIFrameElement>()

components/script/window_named_properties.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,6 @@ pub fn create(
242242
HANDLER.0,
243243
UndefinedHandleValue,
244244
proto.get(),
245-
// TODO: pass proper clasp
246245
&CLASS,
247246
false,
248247
));

0 commit comments

Comments
 (0)