Add dummy function for ownPropertyKeys

pylbrecht · pylbrecht · commit 583b3141bc39 · 2021-05-13T17:46:11.000+02:00
diff --git a/components/script/window_named_properties.rs b/components/script/window_named_properties.rs
@@ -17,9 +17,10 @@ use js::glue::{CreateProxyHandler, NewProxyObject, ProxyTraps, RUST_JSID_IS_STRI
 use js::jsapi::JS_SetImmutablePrototype;
 use js::jsapi::{Handle, HandleObject, JSClass, JSContext, JSErrNum, UndefinedHandleValue};
 use js::jsapi::{
-    HandleId, JSClass_NON_NATIVE, MutableHandle, ObjectOpResult, PropertyDescriptor,
-    ProxyClassExtension, ProxyClassOps, ProxyObjectOps, JSCLASS_DELAY_METADATA_BUILDER,
-    JSCLASS_IS_PROXY, JSCLASS_RESERVED_SLOTS_MASK, JSCLASS_RESERVED_SLOTS_SHIFT,
+    HandleId, JSClass_NON_NATIVE, MutableHandle, MutableHandleIdVector, ObjectOpResult,
+    PropertyDescriptor, ProxyClassExtension, ProxyClassOps, ProxyObjectOps,
+    JSCLASS_DELAY_METADATA_BUILDER, JSCLASS_IS_PROXY, JSCLASS_RESERVED_SLOTS_MASK,
+    JSCLASS_RESERVED_SLOTS_SHIFT,
 };
 use js::jsval::UndefinedValue;
 use js::rust::IntoHandle;
@@ -38,7 +39,7 @@ lazy_static! {
             enter: None,
             getOwnPropertyDescriptor: Some(get_own_property_descriptor),
             defineProperty: Some(define_property),
-            ownPropertyKeys: None,
+            ownPropertyKeys: Some(own_property_keys),
             delete_: Some(delete),
             enumerate: None,
             getPrototypeIfOrdinary: None,
@@ -113,6 +114,16 @@ unsafe extern "C" fn get_own_property_descriptor(
     return true;
 }
 
+#[allow(unsafe_code)]
+unsafe extern "C" fn own_property_keys(
+    _cx: *mut JSContext,
+    _proxy: HandleObject,
+    _props: MutableHandleIdVector,
+) -> bool {
+    // FIXME(pylbrecht): dummy implementation
+    true
+}
+
 #[allow(unsafe_code)]
 unsafe extern "C" fn define_property(
     cx: *mut JSContext,
