This repository was archived by the owner on Nov 12, 2022. It is now read-only.
Add glue methods to get JSValue of a private reference#515
Merged
bors-servo merged 1 commit intoservo:masterfrom Jul 19, 2020
Merged
Add glue methods to get JSValue of a private reference#515bors-servo merged 1 commit intoservo:masterfrom
bors-servo merged 1 commit intoservo:masterfrom
Conversation
Member
Author
|
Btw, I just noticed the Microsoft documentation link in line 1072 is 404 now. I tried to search it but looks like I can't find exactly same one.
But found 2 links might be related; ☝️ is any of them I should update to the comment? |
Member
|
Please file an issue about the broken doc link. |
jdm
suggested changes
Jul 18, 2020
While working on servo/servo#27026, we've noticed calling `GetScriptPrivate` will hit a CRASH consistently in Windows. jdm noticed that this is caused by "can't return JSValue by value on Windows"; thus, we need to expose these 2 glue methods so that we can handle the `GetScriptPrivate` and `GetModulePrivate` correctly.
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit cc7aeda has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on servo/servo#27026, we've noticed calling
GetScriptPrivatewill hit a CRASH consistently in Windows. jdm noticedthat this is caused by "can't return JSValue by value on Windows"; thus,
we need to expose these 2 glue methods so that we can handle the
GetScriptPrivateandGetModulePrivatecorrectly.This will help servo/servo#27026.
We might want to handle the
ModulePrivatemuch more correctly in the future so it might be worth adding it here as well?