This repository was archived by the owner on Nov 12, 2022. It is now read-only.
Allow interior mutability of Heap objects.#328
Merged
bors-servo merged 1 commit intoservo:masterfrom Jan 27, 2017
Merged
Conversation
Author
|
r? @jdm |
4 tasks
Member
|
@bors-servo: r+ |
Contributor
|
📌 Commit 00956df has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Jan 27, 2017
Allow interior mutability of Heap objects. Over in servo/servo#15120, there's an implementation of `WindowProxy` to `Window` bindings, which updates the `WindowProxy` when navigation happens. This requires mutating the reflector, which is a lot easier if `Heap` implements interior mutability. `Heap` already has an `UnsafeCell` internally, so the only change is that `Heap::set` takes a `&self` rather than a `&mut self`. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/328) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
Merged
bors-servo
pushed a commit
that referenced
this pull request
Jan 27, 2017
Bump version. Version bump for #328. r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/329) <!-- Reviewable:end -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Over in servo/servo#15120, there's an implementation of
WindowProxytoWindowbindings, which updates theWindowProxywhen navigation happens. This requires mutating the reflector, which is a lot easier ifHeapimplements interior mutability.Heapalready has anUnsafeCellinternally, so the only change is thatHeap::settakes a&selfrather than a&mut self.This change is