This repository was archived by the owner on Nov 12, 2022. It is now read-only.
Merged
Conversation
Contributor
Author
|
My main fear is that the two out-of-line calls will be terrible for performance. I don't suppose we use |
Ms2ger
force-pushed
the
rooting
branch
2 times, most recently
from
ef6bcbd to
ce5c85c
Compare
Contributor
Author
|
@jdm can you check the fixup commit? I'm not sure if the additional unsafety is worth it. |
Member
|
As mentioned on IRC, I think we should follow jonco's suggestion from servo/servo#13096 (comment) rather than pursue the patch I wrote in that issue. |
Member
|
I'm glad to see the test, though! |
Member
|
@bors-servo: r+ |
Contributor
|
📌 Commit c8f4cab has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Jan 13, 2017
Make Rooted do its job. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/326) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is