Merged
Conversation
jdm
approved these changes
Jan 17, 2026
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
sagudev
force-pushed
the
more-safe-cx-reduced
branch
from
01a26a5 to
41c875a
Compare
This was referenced Jan 18, 2026
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Jan 18, 2026
…s artifacts (#41971) This bump includes some new safe wrappers: servo/mozjs#699 servo/mozjs#700 debugmozjs artifacts: servo/mozjs#544 rooted macros with vectors: servo/mozjs#697 Testing: Done in mozjs repo. Signed-off-by: sagudev <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added safe_* to conversion traits with default impl that fallbacks to unsafe versions.
I made some actual safe impl here, but it was a lot and we need to fix many more stuff for it to make the really safe: https://github.com/sagudev/mozjs/tree/more-safe-cx
Testing: Covered by existing tests