Add JSContext wrapper for bindings with fewer raw pointers.#554
Closed
jdm wants to merge 1 commit intoservo:mainfrom
Closed
Add JSContext wrapper for bindings with fewer raw pointers.#554jdm wants to merge 1 commit intoservo:mainfrom
jdm wants to merge 1 commit intoservo:mainfrom
Conversation
gmorenz
reviewed
Mar 2, 2025
Signed-off-by: Josh Matthews <[email protected]>
22 tasks
Member
|
This was done in #638 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adapts the JSContext type from Servo's bindings, making it more reliable because we can associate it directly with the underlying runtime wrapper.
This wrapper will enable us in the future to remove the unsafety from traits like ToJSValConvertible and FromJSValConvertible, as well as introduce higher-level wrappers of the JSAPI that do not require using unsafe.