Publish and test debugmozjs artifacts#544
Merged
sagudev merged 5 commits intoservo:mainfrom Jan 18, 2026
Merged
Conversation
sagudev
commented
Dec 21, 2024
sagudev
changed the title
sagudev
force-pushed
the
artifact-debugmozjs
branch
from
c740153 to
809d81c
Compare
sagudev
force-pushed
the
artifact-debugmozjs
branch
from
809d81c to
01fbc20
Compare
Member
Author
|
It is possible to test this out from my fork: sagudev@70e95fa, I tried it and it works. |
jdm
approved these changes
Jan 18, 2026
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
sagudev
force-pushed
the
artifact-debugmozjs
branch
from
01fbc20 to
7c048b3
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Jan 18, 2026
…s artifacts (#41971) This bump includes some new safe wrappers: servo/mozjs#699 servo/mozjs#700 debugmozjs artifacts: servo/mozjs#544 rooted macros with vectors: servo/mozjs#697 Testing: Done in mozjs repo. Signed-off-by: sagudev <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR we also generate debugmozjs artifacts (for windows, mac and linux; mobile platforms were skipped). Such artifacts are now loaded by same mechanism as normal ones, so for servo developers it's just matter of switching debugmozjs on and this will now avoid SM compilation. Debugmozjs artifacts are not stripped, as it's users will likely need them for debugging.
Switching between features works because
target/build/mozjs_sys-hash, where hash depends on features (so we get different folder for debugmozjs \o/).Fix #541