Add new PlayerEvent::DurationChanged event#461
Merged
jdm merged 1 commit intoservo:mainfrom Nov 14, 2025
Merged
Conversation
The goal is to add a new event that allows the client to easily handle changes of the media stream's duration (sometimes duration could be imprecise or even identify with significant delay by media engine). Otherwise, the client must distinguish between consecutive `MetadataUpdate` events that differ only in the `duration` element, and handling them with different conditions (example HTMLMediaElement). After this change will be the following `gstbin state - gstplay signal - event` sequence: - new metadata -> `media_info_updated` -> `MetadataUpdate` event - new duration -> `duration_changed` + `media_info_updated` -> `DurationChanged` event + Nothing (already ignored) Fixes (partially): servo/servo#40626 Signed-off-by: Andrei Volykhin <[email protected]>
tharkum
force-pushed
the
player-event-duration-changed
branch
from
2568073 to
59ea0b6
Compare
Contributor
Author
tharkum
added a commit
to tharkum/servo
that referenced
this pull request
Nov 14, 2025
A new event `PlayerEvent::DurationChanged` has been added to the media engine to simplify handling changes in the duration of a media stream (sometimes the duration could be inaccurate or even determined by the media engine with significant delay after the initial metadata was ready). This new event eliminates the need to check conditions for two consecutive `MetadataUpdated` events (the initial metadata and the metadata with the changed duration) during the loading phase. servo-media: - Add new `PlayerEvent::DurationChanged` event (servo/media#461) Testing: No expected changes in test results Fixes: #servo#40626 Signed-off-by: Andrei Volykhin <[email protected]>
tharkum
added a commit
to tharkum/servo
that referenced
this pull request
Nov 14, 2025
A new event `PlayerEvent::DurationChanged` has been added to the media engine to simplify handling changes in the duration of a media stream (sometimes the duration could be inaccurate or even determined by the media engine with significant delay after the initial metadata was ready). This new event eliminates the need to check conditions for two consecutive `MetadataUpdated` events (the initial metadata and the metadata with the changed duration) during the loading phase. servo-media: - Add new `PlayerEvent::DurationChanged` event (servo/media#461) Testing: No expected changes in test results Fixes: #servo#40626 Signed-off-by: Andrei Volykhin <[email protected]>
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Nov 14, 2025
A new event `PlayerEvent::DurationChanged` has been added to the media engine to simplify handling changes in the duration of a media stream (sometimes the duration could be inaccurate or even determined by the media engine with significant delay after the initial metadata was ready). This new event eliminates the need to check conditions for two consecutive `MetadataUpdated` events (the initial metadata and the metadata with the changed duration) during the loading phase. servo-media: - Add new `PlayerEvent::DurationChanged` event (servo/media#461) Testing: No expected changes in test results Fixes: #40626 Signed-off-by: Andrei Volykhin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to add a new event that allows the client to easily handle changes of the media stream's duration (sometimes duration could be imprecise or even identify with significant delay by media engine). Otherwise, the client must distinguish between consecutive
MetadataUpdateevents that differ only in thedurationelement, and handling them with different conditions (example HTMLMediaElement).After this change will be the following
gstbin state - gstplay signal - eventsequence:media_info_updated->MetadataUpdateeventduration_changed+media_info_updated->DurationChangedevent + Nothing (already ignored)Fixes (partially): servo/servo#40626