Skip to content
This repository was archived by the owner on Apr 23, 2026. It is now read-only.

Remove --all-features#320

Closed
Manishearth wants to merge 1 commit into
servo:masterfrom
Manishearth:all-features
Closed

Remove --all-features#320
Manishearth wants to merge 1 commit into
servo:masterfrom
Manishearth:all-features

Conversation

@Manishearth

@Manishearth Manishearth commented Oct 18, 2019 •
edited by nox
Loading

Copy link
Copy Markdown
Member

Fixes the build

This was broken by rust-lang/cargo#7507 , but the previous behavior was that the flags were ignored, so I removed them

r? nox @ferjm

@nox

nox commented Oct 18, 2019

Copy link
Copy Markdown
Contributor

@bors-servo r+

@bors-servo

bors-servo commented Oct 18, 2019

Copy link
Copy Markdown
Contributor

📌 Commit 740551a has been approved by nox

bors-servo pushed a commit that referenced this pull request Oct 18, 2019
Auto merge of #320 - Manishearth:all-features, r=nox
3f89925 
Remove --all-features

Fixes the build

This was broken by rust-lang/cargo#7507 , but the previous behavior was that the flags were ignored, so I removed them

r? nox @ferjm
@bors-servo

bors-servo commented Oct 18, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit 740551a with merge 3f89925...

@bors-servo

bors-servo commented Oct 18, 2019

Copy link
Copy Markdown
Contributor

💔 Test failed - checks-travis

@CYBAI

CYBAI commented Oct 18, 2019

Copy link
Copy Markdown
Member 
error: target `play_media_stream` in package `examples` requires the features: `player`

Consider enabling them by passing, e.g., `--features="player"`

error: target `play_noise` in package `examples` requires the features: `noise`

Consider enabling them by passing, e.g., `--features="noise"`

error: target `simple_player` in package `examples` requires the features: `player`

Consider enabling them by passing, e.g., `--features="player"`

error: target `simple_webrtc` in package `examples` requires the features: `webrtc`

Consider enabling them by passing, e.g., `--features="webrtc"`

@Manishearth

Manishearth commented Oct 18, 2019

Copy link
Copy Markdown
Member Author

@bors-servo r=nox

trying explicit features

@bors-servo

bors-servo commented Oct 18, 2019

Copy link
Copy Markdown
Contributor

📌 Commit a9d9a5e has been approved by nox

@bors-servo

bors-servo commented Oct 18, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit a9d9a5e with merge 09eefc6...

bors-servo pushed a commit that referenced this pull request Oct 18, 2019
Auto merge of #320 - Manishearth:all-features, r=nox
09eefc6 
Remove --all-features

Fixes the build

This was broken by rust-lang/cargo#7507 , but the previous behavior was that the flags were ignored, so I removed them

r? nox @ferjm
@bors-servo

bors-servo commented Oct 18, 2019

Copy link
Copy Markdown
Contributor

💔 Test failed - checks-travis

@Manishearth

Manishearth commented Oct 18, 2019

Copy link
Copy Markdown
Member Author

rust-lang/cargo#7525

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Manishearth @nox @bors-servo @CYBAI