Don't import xml5ever enums into the global namespace #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CI needs #596 first |
mrobinson
approved these changes
Apr 12, 2025
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
Thanks for all the great work moving html5ever toward modern Rust!
This is mostly the same as servo#593 but for xml5ever. Signed-off-by: Simon Wülker <[email protected]>
simonwuelker
force-pushed
the
xml5ever-cleanup
branch
from
0b39395 to
70a3e04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly the same as #593 but for xml5ever.