Conversation
5 tasks
nical
reviewed
Feb 26, 2018
Contributor
nical
left a comment
nical
left a comment
There was a problem hiding this comment.
Looks good modulo the version number. Thanks!
Cargo.toml
Outdated
| [package] | ||
| name = "euclid" | ||
| version = "0.17.0" | ||
| version = "0.18.0" |
Contributor
There was a problem hiding this comment.
This isn't a breaking change, so i'd prefer to make it 0.17.1 instead of 0.18.0.
Contributor
Author
|
@nical done. |
Contributor
|
Thanks! @bors-servo r+ |
Contributor
|
📌 Commit 658b05c has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Feb 27, 2018
Implement to_u32() Fix #237 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/274) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #237
This change is