Remove unused simd implementation of side offsets.#268
Merged
bors-servo merged 1 commit intoservo:masterfrom Jan 30, 2018
Merged
Remove unused simd implementation of side offsets.#268bors-servo merged 1 commit intoservo:masterfrom
bors-servo merged 1 commit intoservo:masterfrom
Conversation
nical
force-pushed
the
rm-sideoffsets-simd
branch
from
17d9d0d to
c51ef0d
Compare
Contributor
Author
|
r? @SimonSapin |
Member
|
Given that the version number is 0.17.0 which is not yet on crates.io: @bors-servo r+ |
Contributor
|
📌 Commit c51ef0d has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Jan 30, 2018
Remove unused simd implementation of side offsets. This is kind of a breaking change for people that enable `--features unstable`. I believe that servo does not use this. I'd rather remove it for now and potentially re-add it or reimplement it when simd in stable rust is a thing and we need simd-ified side offsets. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/268) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is kind of a breaking change for people that enable
--features unstable. I believe that servo does not use this. I'd rather remove it for now and potentially re-add it or reimplement it when simd in stable rust is a thing and we need simd-ified side offsets.This change is