Add inner_rect and outer_rect methods to Rect#260
Merged
bors-servo merged 1 commit intoservo:masterfrom Jan 14, 2018
pyfisch:inner-outer-rect
Merged
Add inner_rect and outer_rect methods to Rect#260bors-servo merged 1 commit intoservo:masterfrom pyfisch:inner-outer-rect
bors-servo merged 1 commit intoservo:masterfrom
pyfisch:inner-outer-rect
Conversation
nical
reviewed
Jan 14, 2018
src/rect.rs
Outdated
| self.size.height - offsets.vertical() | ||
| ) | ||
| ); | ||
| assert!(rect.size.width >= Zero::zero()); |
Contributor
There was a problem hiding this comment.
I would prefer this to be a debug assertion.
Contributor
Author
|
Changed to debug_assert! |
Contributor
|
Thanks! @bors-servo r+ |
Contributor
|
📌 Commit d2ff23e has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Jan 14, 2018
Add inner_rect and outer_rect methods to Rect Closes #258 cc @nical Note: The `outer_rect` method is similar to the existing `inflate` method but more powerful. If `SideOffsets2D` hat a constructor taking two offsets one for each direction the `inflate` method could be removed I guess. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/260) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #258
cc @nical
Note: The
outer_rectmethod is similar to the existinginflatemethod but more powerful. IfSideOffsets2Dhat a constructor taking two offsets one for each direction theinflatemethod could be removed I guess.This change is