Conversation
Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
mukilan
reviewed
Jan 5, 2026
Co-authored-by: Mukilan Thiyagarajan <[email protected]> Signed-off-by: Josh Matthews <[email protected]>
mrobinson
reviewed
Jan 5, 2026
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
Great stuff! A couple minor comments and a question:
|
|
||
| ## Diagnosing a reftest failure | ||
|
|
||
| To see a visual representation of the differences between a test file and its reference file, you can use the [reftest analyzer](../testing.md#analyzing-reftest-results). |
Member
There was a problem hiding this comment.
FWIW, I almost never use the reftest analyzer nowadays and simply do --log-html out.html. I'm not sure if we should recommend one or the other.
Member
Author
There was a problem hiding this comment.
I have exclusively used the analyzer and didn't even know there was an alternative.
Member
There was a problem hiding this comment.
I find that it's a bit easier to use as the analyzer often seems to fail in weird ways for me.
Member
Author
There was a problem hiding this comment.
Let's stick with the existing recommendation for the purposes of this PR, since this is just linking to existing text in the book.
src/contributing/guides/diagnosing-intermittent-wpt-failures.md
Outdated
Show resolved
Hide resolved
src/contributing/guides/diagnosing-intermittent-wpt-failures.md
Outdated
Show resolved
Hide resolved
src/contributing/guides/diagnosing-intermittent-wpt-failures.md
Outdated
Show resolved
Hide resolved
src/contributing/guides/diagnosing-intermittent-wpt-failures.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Josh Matthews <[email protected]>
Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Josh Matthews <[email protected]>
Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Josh Matthews <[email protected]>
Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Josh Matthews <[email protected]>
Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tried to highlight the most common strategies that I use to narrow down the cause of failures in WPT tests. This is useful for cases like servo/servo#41661 where the expected test result changes did not materialize and we ask contributors to help diagnose why.