Skip to content

Conversation

@cdavernas
Copy link
Member

@cdavernas cdavernas commented Aug 14, 2024

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:
Closes #912

What this PR does:

  • Refactors the oauth2 authentication by:
    • Adding a new (optional) endpoints property, used to configure token, revocation and introspection endpoints
    • Addind a new (optional) issuers property, used to configure the trusted issuers of issued tokens, in case it differs from the configured authority
    • Adding a new (optional) request.encoding property, used to configure the encoding of token requests
    • Adding a new (optional) client.authentication property, used to configure how the client should authenticate on the authorization server
  • Adds a new oidc authentication policy
  • Adds both the documentation and schema for the digest authentication
  • Fixes schema documentation (ex: replaced *AuthenticationData instances by *AuthenticationProperties)

- Add the OIDC authentication policy
- Add the schema for the Digest authentication

Signed-off-by: Charles d'Avernas <[email protected]>
@cdavernas cdavernas added change: fix Something isn't working. Impacts in a minor version change. change: documentation Improvements or additions to documentation. It won't impact a version change. change: feature New feature or request. Impacts in a minor version change area: spec Changes in the Specification change: breaking A breaking change that will impact in a major version change. labels Aug 14, 2024
@cdavernas cdavernas added this to the v1.0.0 milestone Aug 14, 2024
Signed-off-by: Charles d'Avernas <[email protected]>
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a few examples in our directory for the CI to run and validate this change?

@cdavernas cdavernas merged commit 1827680 into serverlessworkflow:main Aug 21, 2024
@cdavernas cdavernas deleted the feat-oidc-authentication branch August 21, 2024 14:24
cdavernas added a commit to serverlessworkflow/sdk-net that referenced this pull request Aug 30, 2024
…on and TaskDefinition, addressing serverlessworkflow/specification#996

- feat(Sdk): Added a `Certificate`, `Digest` and `OIDC` authentication schemes, and updated the OAuth2AuthenticationSchemeDefinition, addressing serverlessworkflow/specification#973

Signed-off-by: Charles d'Avernas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: spec Changes in the Specification change: breaking A breaking change that will impact in a major version change. change: documentation Improvements or additions to documentation. It won't impact a version change. change: feature New feature or request. Impacts in a minor version change change: fix Something isn't working. Impacts in a minor version change.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add additional authority endpoints to OAUTH2

2 participants