Fix port schema #924
Merged
Fix port schema #924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Pichler <[email protected]>
matthias-pichler
requested review from
cdavernas and
ricardozanini
as code owners
cdavernas
approved these changes
Jul 17, 2024
Member
cdavernas
left a comment
cdavernas
left a comment
There was a problem hiding this comment.
LGTM! Once again, great catch! Thank you so much for your awesome contributions!
Member
|
I guess you meant |
ricardozanini
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matthias Pichler [email protected]
Please specify parts of this PR update:
Discussion or Issue link:
What this PR does:
the schema for
portwas usingminandmaxfor the range instead of the correctminimumandmaximum.flowDirectivealso had an extraadditionalPropertieswhich is invalid for stringsAdditional information: