Allow expressions in HTTP query and headers #1080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toxik
force-pushed
the
feat/http-expressions-in-headers-and-query
branch
from
b6b4e37 to
7e4b9d7
Compare
cdavernas
changed the title
Member
|
@toxik Thank you for your work! Can I ask you to please open an issue describing the feature the PR addresses? It's important for book keeping purposes 😉 |
Contributor
Author
Member
|
@toxik My bad, missed it by clicking directly on the PR email 😛 |
Member
ricardozanini
left a comment
ricardozanini
left a comment
There was a problem hiding this comment.
Thanks! Can you add an example for this change so we can validate it in our CI? For reference: https://github.com/serverlessworkflow/specification/blob/main/examples/call-http-query-parameters.yaml
Issue serverlessworkflow#1079 Signed-off-by: Alexandru Georoceanu <[email protected]>
toxik
force-pushed
the
feat/http-expressions-in-headers-and-query
branch
from
7e4b9d7 to
37fcaa4
Compare
Contributor
Author
Hey, sure thing – 37fcaa4 |
ricardozanini
approved these changes
Feb 10, 2025
Member
ricardozanini
left a comment
ricardozanini
left a comment
There was a problem hiding this comment.
Outstanding! Many thanks!
nyamathshaik
pushed a commit
to nyamathshaik/specification
that referenced
this pull request
Mar 19, 2025
…workflow#1080) Issue serverlessworkflow#1079 Signed-off-by: Alexandru Georoceanu <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]>
ricardozanini
added a commit
that referenced
this pull request
Mar 19, 2025
* Fix #1076 - Make detail and title a runtime expression in the schema Signed-off-by: Ricardo Zanini <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> * Add string as anyOf Signed-off-by: Ricardo Zanini <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> * feat(schema): allow expressions in HTTP query and headers (#1080) Issue #1079 Signed-off-by: Alexandru Georoceanu <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> * update DSL version from alpha1, alpha2, alpha5 to 1.0.0 across multip… (#1082) * update DSL version from alpha1, alpha2, alpha5 to 1.0.0 across multiple YAML files Signed-off-by: Gilles Barbier <[email protected]> * fix(contributing): reverting pre-release versioning format Signed-off-by: Gilles Barbier <[email protected]> --------- Signed-off-by: Gilles Barbier <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> * Fix the description of flow directives and addressed few issues in dsl and dsl-reference (#1083) * update DSL version from alpha1, alpha2, alpha5 to 1.0.0 across multip… (#1082) * update DSL version from alpha1, alpha2, alpha5 to 1.0.0 across multiple YAML files Signed-off-by: Gilles Barbier <[email protected]> * fix(contributing): reverting pre-release versioning format Signed-off-by: Gilles Barbier <[email protected]> --------- Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl): fix a few issues in dsl and dsl-reference Signed-off-by: Gilles Barbier <[email protected]> * update .gitignore to include .DS_Store Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): correct table formatting Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): clarify flow directive descriptions Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): improve table formatting Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): clarify flow directive descriptions Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl): fix a few issues in dsl and dsl-reference Signed-off-by: Gilles Barbier <[email protected]> * update .gitignore to include .DS_Store Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): correct table formatting Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): clarify flow directive descriptions Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): improve table formatting Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): clarify flow directive descriptions Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): improve table formatting Signed-off-by: Gilles Barbier <[email protected]> * remove again .DS_Store Signed-off-by: Gilles Barbier <[email protected]> --------- Signed-off-by: Gilles Barbier <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> * Fix broken link in README.md (#1084) Signed-off-by: Michal Broz <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> * Set task to support direct runtime expression Signed-off-by: Nyamath Shaik <[email protected]> * updated workflow schema along with table fix Signed-off-by: Nyamath Shaik <[email protected]> * updating the schema Signed-off-by: Nyamath Shaik <[email protected]> * addressing PR comment reviews Signed-off-by: Nyamath Shaik <[email protected]> * removing unwanted set example Signed-off-by: Nyamath Shaik <[email protected]> * Update dsl-reference.md Co-authored-by: Charles d'Avernas <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> * Update dsl-reference.md Co-authored-by: Charles d'Avernas <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> * Update dsl-reference.md Co-authored-by: Charles d'Avernas <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> * reverting back original set example change Signed-off-by: Nyamath Shaik <[email protected]> * Update dsl-reference.md Co-authored-by: Charles d'Avernas <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> * passing the set example as object Signed-off-by: Nyamath Shaik <[email protected]> * reverting to original Signed-off-by: Nyamath Shaik <[email protected]> * Add a new file that compares the Serverless Workflow to other popular DSLs Signed-off-by: Charles d'Avernas <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> * Fix a the `catalog` link in the `use` section table (#1088) Signed-off-by: Charles d'Avernas <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> --------- Signed-off-by: Ricardo Zanini <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> Signed-off-by: Alexandru Georoceanu <[email protected]> Signed-off-by: Gilles Barbier <[email protected]> Signed-off-by: Michal Broz <[email protected]> Signed-off-by: Charles d'Avernas <[email protected]> Co-authored-by: Ricardo Zanini <[email protected]> Co-authored-by: Alexandru Georoceanu <[email protected]> Co-authored-by: Gilles Barbier <[email protected]> Co-authored-by: mbroz2 <[email protected]> Co-authored-by: Charles d'Avernas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please specify parts of this PR update:
Discussion or Issue link:
#1079
What this PR does:
Additional information: