Parse funcRef refName correctly #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jort Rodenburg <[email protected]>
jjrodenburg
force-pushed
the
CorrectlyParseFunctionRefRefName
branch
from
078d0a3 to
fa8d827
Compare
ricardozanini
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
When parsing the workflow, function.go sets the refname to a hardcoded "refName" string. This skips any refName set in the YAML/JSON.
Instead, we should use the available funcRef map to grab the "refName" value.
Special notes for reviewers:
Additional information (if needed):
Co-PR with @VicNgu