Skip to content

Config Schema: Fix provider validation#8450

Merged
medikoo merged 1 commit into
masterfrom
1028-fix-provider-validation
Oct 29, 2020
Merged

Config Schema: Fix provider validation#8450
medikoo merged 1 commit into
masterfrom
1028-fix-provider-validation

Conversation

@medikoo

@medikoo medikoo commented Oct 28, 2020

Copy link
Copy Markdown
Contributor

Addresses issue described here: #8330 (comment) by @thewizarodofoz

Ensure to test provider config as put on in service config

@medikoo medikoo self-assigned this Oct 28, 2020
@medikoo
medikoo force-pushed the 1028-fix-provider-validation branch from 5df66e9 to 5e3af2b Compare October 28, 2020 16:31
@codecov-io

codecov-io commented Oct 28, 2020

Copy link
Copy Markdown

Codecov Report

Merging #8450 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8450      +/-   ##
==========================================
- Coverage   88.04%   88.04%   -0.01%     
==========================================
  Files         249      249              
  Lines        9300     9299       -1     
==========================================
- Hits         8188     8187       -1     
  Misses       1112     1112              
Impacted Files Coverage Δ
lib/classes/Service.js 85.36% <ø> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 989bd66...5e3af2b. Read the comment docs.

@medikoo medikoo changed the title Config Schema: Fix provider validation Config Schema: Fix provider validation Oct 28, 2020
@medikoo
medikoo merged commit b04ab55 into master Oct 29, 2020
@medikoo
medikoo deleted the 1028-fix-provider-validation branch October 29, 2020 08:27
@medikoo medikoo mentioned this pull request Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants