Remaining eventInvokeConfig properties on functions[] schema#8385
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8385 +/- ##
==========================================
- Coverage 88.02% 88.01% -0.01%
==========================================
Files 249 249
Lines 9278 9281 +3
==========================================
+ Hits 8167 8169 +2
- Misses 1111 1112 +1
Continue to review full report at Codecov.
|
medikoo
reviewed
Oct 12, 2020
medikoo
left a comment
medikoo
left a comment
Contributor
There was a problem hiding this comment.
@fredericbarthelet looks great! Thank you, I have just one minor cleanup suggestion
fredericbarthelet
force-pushed
the
functions-schema
branch
from
October 12, 2020 16:53
094c23b to
73ee603
Compare
medikoo
approved these changes
Oct 13, 2020
medikoo
left a comment
medikoo
left a comment
Contributor
There was a problem hiding this comment.
Thank you @fredericbarthelet !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #8017