Aws provider apigateway schema#8383
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8383 +/- ##
==========================================
- Coverage 88.02% 88.00% -0.02%
==========================================
Files 249 249
Lines 9278 9264 -14
==========================================
- Hits 8167 8153 -14
Misses 1111 1111 ☔ View full report in Codecov by Sentry. |
medikoo
left a comment
medikoo
left a comment
There was a problem hiding this comment.
Thank you @thewizarodofoz ! Looks really good, please see my remarks
| limit: { type: 'integer' }, | ||
| offset: { type: 'integer' }, |
There was a problem hiding this comment.
It'll be nice to restrict minimum to 0
| additionalProperties: false, | ||
| }, | ||
| }, | ||
| required: [], |
There was a problem hiding this comment.
Let's not add empty required
medikoo
left a comment
medikoo
left a comment
There was a problem hiding this comment.
Thank you @thewizarodofoz looks great! I've just commented on one last minor nuance, and we're ready to go!
| burstLimit: { type: 'integer' }, | ||
| rateLimit: { type: 'integer' }, |
There was a problem hiding this comment.
Let's also put minimum: 0 on those
medikoo
left a comment
medikoo
left a comment
There was a problem hiding this comment.
Thank you @thewizarodofoz !
3 participants
Closes: #8018