Skip to content

feat(AJV): Add Rest api logs definition#8309

Merged
medikoo merged 4 commits into
serverless:masterfrom
fredericbarthelet:rest-api-logs-definition
Sep 30, 2020
Merged

feat(AJV): Add Rest api logs definition#8309
medikoo merged 4 commits into
serverless:masterfrom
fredericbarthelet:rest-api-logs-definition

Conversation

@fredericbarthelet

@fredericbarthelet fredericbarthelet commented Sep 30, 2020

Copy link
Copy Markdown
Contributor

Addresses: #8018

medikoo
medikoo suggested changes Sep 30, 2020
View reviewed changes

@medikoo medikoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears tests relied on apiGatewayValidLogLevels (see CI fail). If its' indeed needed over there, I would just hardcode it to test file

@fredericbarthelet

fredericbarthelet commented Sep 30, 2020

Copy link
Copy Markdown
Contributor Author

It appears tests relied on apiGatewayValidLogLevels (see CI fail). If its' indeed needed over there, I would just hardcode it to test file

Hardcoded it for the tests that needs it.

medikoo
medikoo reviewed Sep 30, 2020
View reviewed changes

@medikoo medikoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fredericbarthelet it looks great. I have just one minor improvement suggestion. Let me know

Comment thread lib/plugins/aws/provider/awsProvider.js
@codecov-commenter

codecov-commenter commented Sep 30, 2020

Copy link
Copy Markdown

Codecov Report

Merging #8309 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8309      +/-   ##
==========================================
- Coverage   88.09%   88.08%   -0.01%     
==========================================
  Files         250      250              
  Lines        9371     9368       -3     
==========================================
- Hits         8255     8252       -3     
  Misses       1116     1116
Impacted Files Coverage Δ
.../compile/events/apiGateway/lib/hack/updateStage.js 95.06% <ø> (-0.09%) ⬇️
lib/plugins/aws/provider/awsProvider.js 93.21% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8293cc4...173294d. Read the comment docs.

medikoo
medikoo approved these changes Sep 30, 2020
View reviewed changes

@medikoo medikoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fredericbarthelet !

@medikoo
medikoo merged commit dd9a011 into serverless:master Sep 30, 2020
This was referenced Sep 30, 2020
Closed
Merged
@medikoo medikoo mentioned this pull request Oct 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@medikoo medikoo medikoo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@fredericbarthelet fredericbarthelet

Labels

cat/aws-event-api-gateway cat/config-schema enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fredericbarthelet @codecov-commenter @medikoo