Aws alb schema#8291
Conversation
# Conflicts: # lib/plugins/aws/package/compile/events/alb/lib/validate.js # lib/plugins/aws/provider/awsProvider.js
Codecov Report
@@ Coverage Diff @@
## master #8291 +/- ##
==========================================
- Coverage 88.16% 88.12% -0.05%
==========================================
Files 250 250
Lines 9391 9365 -26
==========================================
- Hits 8280 8253 -27
- Misses 1111 1112 +1
Continue to review full report at Codecov.
|
medikoo
left a comment
medikoo
left a comment
There was a problem hiding this comment.
wow, that looks great @thewizarodofoz ! I've spotted just some minor shortcomings, please see my comments
medikoo
left a comment
medikoo
left a comment
There was a problem hiding this comment.
Thanks @thewizarodofoz for update! Still, I see some comments not addressed/answered, have you pushed all the commits?
medikoo
left a comment
medikoo
left a comment
There was a problem hiding this comment.
Thanks @thewizarodofoz, still as I see CI tests fail because regex is not right for httpCode (It has literal d instead of \d which defines digit - in a string we need to input as \\d)
medikoo
left a comment
medikoo
left a comment
There was a problem hiding this comment.
@thewizarodofoz looks great! I've just spotted two suggestions not answered/addressed. See my comments
medikoo
left a comment
medikoo
left a comment
There was a problem hiding this comment.
Thank you @thewizarodofoz !
3 participants
Closes: #8020
Notes:
listenerArn.match(ALB_LISTENER_PATTERN)invalidate.jsbecause it's used as a parser. Feels weird importing it inawsProviderfor validating but couldn't think of a better wayconditions.header.name- I didn't specify the pattern, seems like an overkillhealthCheck.mather.httpCode- I didn't specify the pattern, found it very hard to do