Add base definition of properties by fredericbarthelet · Pull Request #8222 · serverless/serverless

fredericbarthelet · 2020-09-11T11:43:24Z

Closes: #8017
Addresses: #8016

codecov-commenter · 2020-09-11T11:45:19Z

Codecov Report

Merging #8222 into master will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #8222      +/-   ##
==========================================
- Coverage   88.10%   88.04%   -0.06%     
==========================================
  Files         248      248              
  Lines        9384     9329      -55     
==========================================
- Hits         8268     8214      -54     
+ Misses       1116     1115       -1

Impacted Files	Coverage Δ
lib/configSchema.js	`100.00% <ø> (ø)`
lib/plugins/aws/provider/awsProvider.js	`93.11% <ø> (ø)`
lib/classes/ConfigSchemaHandler/index.js	`89.52% <100.00%> (ø)`
lib/plugins/aws/package/compile/functions/index.js	`97.03% <100.00%> (-0.22%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e9e6aa...3a30bbe. Read the comment docs.

medikoo · 2020-09-14T11:55:47Z

@fredericbarthelet is this intentionally posted as draft pull request?

fredericbarthelet · 2020-09-14T13:09:58Z

@medikoo yes it is intentional, I'm not quite finished yet on this one :) Should be completed by the end of the day

fredericbarthelet · 2020-09-15T16:01:01Z

@medikoo this PR is now ready for review when you can :)

medikoo

@fredericbarthelet great thanks for that!

In master I've reordered definitions so alphabetical order is respected, and I see now this branch conflicts due to that. Can you rebase it against master?

fredericbarthelet · 2020-09-16T13:47:29Z

@medikoo I sorted the properties :) Let me know what you think

medikoo

@fredericbarthelet that looks outstanding! Great thanks for that. Please see my remarks, and let me know what you think

fredericbarthelet · 2020-09-20T13:13:38Z

@medikoo I took into account all of your comments. Could you have another look at my PR and let me know if something is still missing ? thanks :)

medikoo

Thanks @fredericbarthelet it looks very good! We're nearly there, please see my comments

fredericbarthelet · 2020-09-21T13:51:48Z

@medikoo updated my PR with your latest comments :)

medikoo

@fredericbarthelet sorry for confusion. Tests exposed that actually package.individually is supported on function level (my bad - I totally forgot it's the case).

In light of that, we need to recognize that option on function level

fredericbarthelet · 2020-09-21T14:27:20Z

@medikoo no problem, updated it with allowed individually property at function level :)

medikoo

@fredericbarthelet that looks great!

I have just last few minor (totally nit picking) style suggestions, so we're noise free and consistent. Let me know

fredericbarthelet · 2020-09-21T14:43:48Z

@medikoo no problem, updated to match alphabetical order and removed unecessary awsKmsArnString definition

medikoo

Thank you @fredericbarthelet !

fredericbarthelet marked this pull request as draft September 11, 2020 11:43

fredericbarthelet force-pushed the schema-functions branch 3 times, most recently from 19a831a to daefbee Compare September 15, 2020 15:38

fredericbarthelet marked this pull request as ready for review September 15, 2020 16:00

medikoo added cat/config-schema enhancement labels Sep 16, 2020

medikoo assigned fredericbarthelet Sep 16, 2020

medikoo reviewed Sep 16, 2020

View reviewed changes

fredericbarthelet force-pushed the schema-functions branch from 928e564 to 1397042 Compare September 16, 2020 13:46

fredericbarthelet requested a review from medikoo September 16, 2020 13:47

medikoo suggested changes Sep 17, 2020

View reviewed changes

medikoo added the cat/lambda label Sep 17, 2020

medikoo mentioned this pull request Sep 18, 2020

Type Error bug when runing "sls invoke local -f ..." @version2.1.0. Not problem on version 1.80.0 #8263

Closed

fredericbarthelet force-pushed the schema-functions branch 4 times, most recently from df10779 to 28bc5fa Compare September 20, 2020 12:56

fredericbarthelet requested a review from medikoo September 20, 2020 13:13

fredericbarthelet force-pushed the schema-functions branch from 34aef93 to 72211f7 Compare September 20, 2020 13:14

medikoo suggested changes Sep 21, 2020

View reviewed changes

Comment thread lib/plugins/aws/provider/awsProvider.js Outdated

Comment thread lib/plugins/aws/provider/awsProvider.js Outdated

Comment thread lib/plugins/aws/provider/awsProvider.js Outdated

fredericbarthelet added 3 commits September 21, 2020 15:51

Add base definition of properties

55e2ff7

Add memorySize for provider and function

b22002d

Add timeout for provider and function

41df618

fredericbarthelet added 14 commits September 21, 2020 15:51

Add tracing

ac8236e

Remove unecessary tests

e5bbfce

Add environment and role

9fc2325

Add remaining properties

263e543

remove tests

ae6496b

Invert arn service order

abdcb61

Remove tests

bdf2aae

Sort awsProviders properties new keys

64b44bb

PR feedbacks

1bf37e9

Update lambda environment allowed values

48873a2

Add package definition

c9b9bcf

Use awsKmsArn definition everywhere

cc869c0

Add package, condition and dependsOn property

efcc5ad

Use same kmsArn definition with cfIntrinsics function definition

8939273

fredericbarthelet force-pushed the schema-functions branch from 72211f7 to eafcb91 Compare September 21, 2020 13:51

fredericbarthelet requested a review from medikoo September 21, 2020 13:51

fredericbarthelet force-pushed the schema-functions branch from eafcb91 to 17a4da7 Compare September 21, 2020 13:53

medikoo suggested changes Sep 21, 2020

View reviewed changes

Update package definition

9e25629

fredericbarthelet force-pushed the schema-functions branch from 17a4da7 to 9e25629 Compare September 21, 2020 14:26

fredericbarthelet requested a review from medikoo September 21, 2020 14:27

medikoo reviewed Sep 21, 2020

View reviewed changes

Comment thread lib/configSchema.js Outdated

Comment thread lib/plugins/aws/provider/awsProvider.js Outdated

Comment thread lib/plugins/aws/provider/awsProvider.js Outdated

Alphabetical order

3a30bbe

fredericbarthelet requested a review from medikoo September 21, 2020 14:43

medikoo approved these changes Sep 21, 2020

View reviewed changes

medikoo merged commit feece9a into serverless:master Sep 21, 2020

medikoo mentioned this pull request Sep 22, 2020

Config schema: Define AWS "http" function event properties #8018

Closed

8 tasks

Uh oh!

Conversation

fredericbarthelet commented Sep 11, 2020

Uh oh!

codecov-commenter commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

medikoo commented Sep 14, 2020

Uh oh!

fredericbarthelet commented Sep 14, 2020

Uh oh!

fredericbarthelet commented Sep 15, 2020

Uh oh!

medikoo left a comment

Choose a reason for hiding this comment

Uh oh!

fredericbarthelet commented Sep 16, 2020

Uh oh!

medikoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fredericbarthelet commented Sep 20, 2020

Uh oh!

medikoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fredericbarthelet commented Sep 21, 2020

Uh oh!

medikoo left a comment

Choose a reason for hiding this comment

Uh oh!

fredericbarthelet commented Sep 21, 2020

Uh oh!

medikoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fredericbarthelet commented Sep 21, 2020

Uh oh!

medikoo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-commenter commented Sep 11, 2020 •

edited

Loading