Local invoke AWS CF function resolution for env variable : Ref#8198
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8198 +/- ##
==========================================
- Coverage 88.21% 88.17% -0.04%
==========================================
Files 248 249 +1
Lines 9460 9475 +15
==========================================
+ Hits 8345 8355 +10
- Misses 1115 1120 +5
Continue to review full report at Codecov.
|
|
@medikoo I could add an intermediate service responsible for resolving both imports and refs in order to simplify invoke local code and abstracting away the different functions that can be resolved. Would you prefer such service to be implemented or do you like it better this way ? |
medikoo
left a comment
medikoo
left a comment
There was a problem hiding this comment.
Thank you @fredericbarthelet it looks good! Still let me know what you think about my suggetsions
@medikoo I could add an intermediate service responsible for resolving both imports and refs in order to simplify invoke local code and abstracting away the different functions that can be resolved. Would you prefer such service to be implemented or do you like it better this way ?
Do you think, we can (and should) use it then in some other places? If yes, then yes I think it might be nice to abstract it away.
94d5c18 to
6ffeef9
Compare
|
@medikoo I updated my PR with your comments. I don't see any use yet for a service requiring as well import and ref intrinsic functions. When the case arise, I shall implement such service. |
medikoo
left a comment
medikoo
left a comment
There was a problem hiding this comment.
Thank you @fredericbarthelet looks great. Still shouldn't we also mention support for Ref in docs here: https://github.com/fredericbarthelet/serverless/blob/13e1bf7a7d2aba877a2cbd6e3c0c59689fbe8964/docs/providers/aws/cli-reference/invoke-local.md#local-function-invocation-setting-environment-variables ?
6ffeef9 to
c2554d8
Compare
|
@medikoo you're right, I updated the documentation as well :) |
medikoo
left a comment
medikoo
left a comment
There was a problem hiding this comment.
Thank you @fredericbarthelet !
3 participants
Addresses: #7087 #8147