feat(aws): add iot event schema#8177
Merged
Merged
Conversation
pgrzesik
force-pushed
the
add-aws-iot-event-schema
branch
from
September 2, 2020 15:01
a46d0fb to
2c97dc7
Compare
Codecov Report
@@ Coverage Diff @@
## master #8177 +/- ##
==========================================
- Coverage 88.22% 88.21% -0.01%
==========================================
Files 248 248
Lines 9459 9460 +1
==========================================
Hits 8345 8345
- Misses 1114 1115 +1
Continue to review full report at Codecov.
|
medikoo
suggested changes
Sep 2, 2020
| const ruleName = event.iot.name ? event.iot.name.replace(/\r?\n/g, '') : ''; | ||
| const awsIotSqlVersion = event.iot.sqlVersion | ||
| ? event.iot.sqlVersion.replace(/\r?\n/g, '') | ||
| : ''; |
medikoo
approved these changes
Sep 3, 2020
medikoo
pushed a commit
that referenced
this pull request
Sep 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add IoT Event Schema + minor cleanup
Closes: #8030