Skip to content

Fix Fn:Sub function definition#8174

Merged
medikoo merged 1 commit into
serverless:masterfrom
fredericbarthelet:fix-fn-sub
Sep 2, 2020
Merged

Fix Fn:Sub function definition#8174
medikoo merged 1 commit into
serverless:masterfrom
fredericbarthelet:fix-fn-sub

Conversation

@fredericbarthelet

Copy link
Copy Markdown
Contributor

Closes: #8173

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #8174 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8174   +/-   ##
=======================================
  Coverage   88.25%   88.25%           
=======================================
  Files         248      248           
  Lines        9454     9454           
=======================================
  Hits         8344     8344           
  Misses       1110     1110           
Impacted Files Coverage Δ
lib/plugins/aws/provider/awsProvider.js 93.11% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f7f9d3...164e590. Read the comment docs.

@medikoo medikoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fredericbarthelet, great you've picked that before release

@medikoo
medikoo merged commit 72e77f5 into serverless:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SNS schema validation fails with string : wrong Fn::Sub definition

3 participants