Skip to content

Issue 7008 default request templates#8159

Merged
medikoo merged 3 commits into
serverless:masterfrom
jormaechea:Issue-7008-default-request-templates
Sep 1, 2020
Merged

Issue 7008 default request templates#8159
medikoo merged 3 commits into
serverless:masterfrom
jormaechea:Issue-7008-default-request-templates

Conversation

@jormaechea

Copy link
Copy Markdown
Contributor

Closes: #7008

@codecov-commenter

codecov-commenter commented Aug 31, 2020

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.24%. Comparing base (56aa5aa) to head (aa9f8fa).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8159      +/-   ##
==========================================
+ Coverage   88.18%   88.24%   +0.05%     
==========================================
  Files         248      248              
  Lines        9444     9424      -20     
==========================================
- Hits         8328     8316      -12     
+ Misses       1116     1108       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@medikoo medikoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jormaechea that looks great! I've just proposed one minor style improvement

Comment thread lib/plugins/aws/package/compile/events/apiGateway/lib/method/integration.js Outdated
@jormaechea

Copy link
Copy Markdown
Contributor Author

@medikoo Updated!

@jormaechea
jormaechea requested a review from medikoo September 1, 2020 14:11

@medikoo medikoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jormaechea that looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow for the removal of default request mapping templates

3 participants