Local invoke AWS CF function resolution for env variable : Fn::ImportValue by fredericbarthelet · Pull Request #8157 · serverless/serverless

fredericbarthelet · 2020-08-31T12:04:23Z

This PR uses work already done in #7147
It is focus only on Fn::ImportValue resolution as the service resolveCfImportValue already exists within Serverless framework and is currently in use by getStackInfo service for httpApi external id import resolution.
Additional PRs will be issued to implement as well GetAtt and Ref function resolution.

Addresses: #7087 #8147

codecov-commenter · 2020-08-31T12:06:17Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.23%. Comparing base (87fd3c1) to head (49796ba).

Files with missing lines	Patch %	Lines
lib/plugins/aws/info/getStackInfo.js	50.00%	1 Missing ⚠️
lib/plugins/aws/invokeLocal/index.js	93.75%	1 Missing ⚠️
lib/plugins/aws/utils/resolveCfImportValue.js	50.00%	1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8157      +/-   ##
==========================================
+ Coverage   88.21%   88.23%   +0.02%     
==========================================
  Files         248      248              
  Lines        9416     9421       +5     
==========================================
+ Hits         8306     8313       +7     
+ Misses       1110     1108       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

medikoo

Thanks @fredericbarthelet! It looks promising. Please see my comment

fredericbarthelet · 2020-09-01T09:13:17Z

@medikoo I updated my PR with your comments :)

medikoo

Thank you @fredericbarthelet that looks great. I've left just one minor remark

medikoo

@fredericbarthelet looks great, still I've just noticed one last minor (DX related) thing.

medikoo

Thank you @fredericbarthelet !

… env vars (PR #8157)

maghirardelli · 2022-10-04T21:44:35Z

How would these changes be used within a serverless.yaml file? I am currently using it as this and still getting my env variable set as [object Object]:

custom:
  backendTools:
    environmentOverrides: 
      lambdas:
        lambdaName:
          environment:
            LOCAL_ARN:
              'Fn::ImportValue': '${AuthenticationLayerHandlerRoleArn}'

medikoo · 2022-10-05T08:53:12Z

@maghirardelli are you using plugin to port those env variables to lambda. Also do you see [object Object] in actual lambda, or maybe local invocation?

maghirardelli · 2022-10-05T14:07:19Z

@medikoo I am not using a plugin to port those env variable to lambda. I am running sls offline so local invocation.

medikoo · 2022-10-05T14:08:30Z

@maghirardelli In case of local invocation cloudformation intristic functions are not supported.

maghirardelli · 2022-10-05T14:11:13Z

@medikoo Oh, I thought that was what this PR was adding support for. What does this PR do then?

medikoo · 2022-10-05T14:17:49Z

@maghirardelli indeed, I totally forgot we've got partial support, and resolve Fn::ImportValue and Ref if possible.

Still environment variables for functions are configured either at provider.environment or functions[].environment, while you refer to configuration in custom block (hence by question about plugins)

maghirardelli · 2022-10-05T14:25:31Z

@medikoo Ah, that makes sense. Thanks for the info and the speedy responses!

fredericbarthelet commented Aug 31, 2020

View reviewed changes

Comment thread lib/plugins/aws/invokeLocal/index.js Outdated

medikoo suggested changes Sep 1, 2020

View reviewed changes

Comment thread lib/plugins/aws/utils/resolveCfFunctionValue.js Outdated

Comment thread lib/plugins/aws/invokeLocal/index.js Outdated

Comment thread lib/plugins/aws/invokeLocal/index.js Outdated

fredericbarthelet force-pushed the import-value-env-resolution branch from 6359980 to 01b1c9d Compare September 1, 2020 09:08

fredericbarthelet requested a review from medikoo September 1, 2020 10:15

medikoo reviewed Sep 1, 2020

View reviewed changes

Comment thread lib/plugins/aws/info/getStackInfo.js Outdated

Comment thread lib/plugins/aws/info/getStackInfo.js Outdated

fredericbarthelet force-pushed the import-value-env-resolution branch 3 times, most recently from f00e6e6 to 2d0317d Compare September 1, 2020 11:18

fredericbarthelet requested a review from medikoo September 1, 2020 11:19

medikoo reviewed Sep 1, 2020

View reviewed changes

Comment thread lib/plugins/aws/utils/resolveCfImportValue.js Outdated

fredericbarthelet added 6 commits September 1, 2020 14:41

Implement Fn::ImportValue env var resolution for local invokation

2cb5475

Simplify getStackApi with resolveCfFunctionValue service

511ff0c

Add memoizee to resolveCfFunctionValue service

6845584

Use PR feedbacks

d46668f

Add error handling for getStackInfo above result processing

41a1dea

Use ServerlessError in resolveCfImportValue

49796ba

fredericbarthelet force-pushed the import-value-env-resolution branch from 2d0317d to 49796ba Compare September 1, 2020 12:44

fredericbarthelet requested a review from medikoo September 1, 2020 12:44

medikoo approved these changes Sep 1, 2020

View reviewed changes

medikoo merged commit 06ed01b into serverless:master Sep 1, 2020

medikoo added cat/local-dev enhancement labels Sep 1, 2020

medikoo pushed a commit that referenced this pull request Sep 1, 2020

feat(AWS Local Invocation): Resolve "Fn::ImportValue" instructions in…

217c975

… env vars (PR #8157)

This was referenced Sep 9, 2020

Environment variables are not resolved same way for remote and local invocations #7087

Closed

Invoke Local: Automatically add environment variables from yaml file #7147

Closed

herebebogans mentioned this pull request Dec 22, 2020

Support Resolution of Cloudformation referenced environment variables dherault/serverless-offline#1149

Open

Uh oh!

Conversation

fredericbarthelet commented Aug 31, 2020

Uh oh!

Uh oh!

codecov-commenter commented Aug 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

medikoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fredericbarthelet commented Sep 1, 2020

Uh oh!

medikoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

medikoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

medikoo left a comment

Choose a reason for hiding this comment

Uh oh!

maghirardelli commented Oct 4, 2022

Uh oh!

medikoo commented Oct 5, 2022

Uh oh!

maghirardelli commented Oct 5, 2022

Uh oh!

medikoo commented Oct 5, 2022

Uh oh!

maghirardelli commented Oct 5, 2022

Uh oh!

medikoo commented Oct 5, 2022

Uh oh!

maghirardelli commented Oct 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-commenter commented Aug 31, 2020 •

edited

Loading