Skip to content

Config schema improvements#8144

Merged
medikoo merged 6 commits into
masterfrom
0828-move-aws-definitions
Aug 28, 2020
Merged

Config schema improvements#8144
medikoo merged 6 commits into
masterfrom
0828-move-aws-definitions

Conversation

@medikoo

@medikoo medikoo commented Aug 28, 2020

Copy link
Copy Markdown
Contributor
  • Ensure to validate direct user config input (where applicable)
  • Allow providers to provide its own definitions. Make AWS specific definitions to be defined by AWS provider
  • Define resources fully in context of provider (move current definition to AWS provider context)

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #8144 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8144      +/-   ##
==========================================
- Coverage   88.28%   88.28%   -0.01%     
==========================================
  Files         248      248              
  Lines        9432     9429       -3     
==========================================
- Hits         8327     8324       -3     
  Misses       1105     1105              
Impacted Files Coverage Δ
lib/configSchema.js 100.00% <ø> (ø)
lib/plugins/aws/provider/awsProvider.js 92.85% <ø> (ø)
lib/classes/ConfigSchemaHandler/index.js 85.10% <100.00%> (+0.32%) ⬆️
lib/classes/Service.js 88.79% <100.00%> (-0.47%) ⬇️
lib/plugins/package/lib/packageService.js 86.06% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f85543...41ead57. Read the comment docs.

@medikoo
medikoo merged commit ffd1b36 into master Aug 28, 2020
@medikoo
medikoo deleted the 0828-move-aws-definitions branch August 28, 2020 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants