Allow use of CF ImportValue for httpApi id#7905
Conversation
c811f6f to
cb6a91c
Compare
Codecov Report
@@ Coverage Diff @@
## master #7905 +/- ##
==========================================
- Coverage 88.30% 88.27% -0.03%
==========================================
Files 244 245 +1
Lines 9082 9095 +13
==========================================
+ Hits 8020 8029 +9
- Misses 1062 1066 +4
Continue to review full report at Codecov.
|
medikoo
left a comment
medikoo
left a comment
There was a problem hiding this comment.
Thank you @fredericbarthelet! I've proposed some minor improvements, but in general it looks great
| const serverless = new Serverless(); | ||
| provider = new AwsProvider(serverless, {}); | ||
| providerStub = sinon.stub(provider, 'request'); |
There was a problem hiding this comment.
Let's not use Serverless and AwsProvider, there's a lot of machinery in them which may introduce side effects.
I would simply inject plain provider object with request method that returns pre-prepared responses.
|
@medikoo I updated the PR according to your comments. Let me know if it's fine now :) |
fdd3e01 to
a4ef428
Compare
medikoo
left a comment
medikoo
left a comment
There was a problem hiding this comment.
Thank you @fredericbarthelet It looks very good. I've just proposed to move one condition into more accurate (logically) point
a4ef428 to
d5431a9
Compare
|
PR updated @medikoo :) |
medikoo
left a comment
medikoo
left a comment
There was a problem hiding this comment.
Thank you @fredericbarthelet !
3 participants
Closes: #7791