feat(dev): add option --on-exit=remove#13342
Merged
Conversation
Co-authored-by: Codex
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
📝 WalkthroughWalkthroughThe dev command option Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
czubocha
changed the title
… into codex/assess-onexit-enum-option
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/serverless/test/unit/lib/plugins/aws/dev.test.js`:
- Around line 80-92: The test currently validates the thrown message but then
uses a try/catch that won’t fail if validateOnExitOption() stops throwing;
update the test for awsDev.validateOnExitOption() so it asserts both the thrown
message and the error.code in one check — either call validateOnExitOption()
inside a try/catch that calls fail() if no error is thrown and then assert
caughtError.code === 'INVALID_DEV_ON_EXIT_OPTION', or use Jest’s expect(() =>
awsDev.validateOnExitOption()).toThrow() variant that inspects the thrown error
and asserts its message and code together; ensure you reference
awsDev.options['on-exit'] === 'foo' and the error code
'INVALID_DEV_ON_EXIT_OPTION' in the assertion.
eahefnawy
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serverless devexit flag from--remove-on-exitto--on-exitinpackages/serverless/lib/cli/commands-schema.js--on-exit=removeis accepted inpackages/serverless/lib/plugins/aws/dev/index.js--on-exitis omitted (show reminder warning)docs/sf/providers/aws/cli-reference/dev.md--on-exitvalues inpackages/serverless/test/unit/lib/plugins/aws/dev.test.jsTest plan
npm run test:unit -w @serverless/framework -- packages/serverless/test/unit/lib/plugins/aws/dev.test.js1 passed, 1 totalsuite and3 passed, 3 totaltestsHow to test
serverless dev --on-exit=remove, pressCtrl+C, and confirm the remove prompt appears.serverless dev --on-exit=fooand confirm it fails withINVALID_DEV_ON_EXIT_OPTION.serverless devwithout--on-exitand confirm the default reminder warning is shown on exit.serverless dev --remove-on-exitand confirm the option is rejected as unsupported.Summary by CodeRabbit
Documentation
Chores
Tests