Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
📝 WalkthroughWalkthroughThe pull request adds support for TLS 1.3 enhanced security policies in API Gateway custom domains. The implementation removes TLS_1_3 from legacy mappings, adds logic to pass through enhanced SecurityPolicy_* values directly, and includes comprehensive test coverage for the policy handling. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
eahefnawy
left a comment
There was a problem hiding this comment.
Interesting, I didn't know TLS 1.3 isn't easily supported by AWS.
Add support for TLS 1.3 enhanced security policies in custom domains
Closes #13290
Problem
Users couldn't configure API Gateway custom domains with AWS's enhanced security policies like
SecurityPolicy_TLS13_2025_EDGE. The framework only accepted legacytls_1_0andtls_1_2values, throwing an error for any other input:Solution
Modified the security policy validation to:
SecurityPolicy_is now passed directly to AWS API Gatewaytls_1_0,tls_1_2) continue to worktls_1_3- This was never a valid AWS value; TLS 1.3 is only available throughSecurityPolicy_*policiesAWS API Reference
Per AWS CreateDomainName API, valid
securityPolicyvalues are:TLS_1_0,TLS_1_2SecurityPolicy_TLS13_2025_EDGE,SecurityPolicy_TLS13_1_3_2025_09,SecurityPolicy_TLS12_PFS_2025_EDGE, etc.Usage
Changes
tls_1_3entrySummary by CodeRabbit
New Features
Improvements
✏️ Tip: You can customize this high-level summary in your review settings.