Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
📝 WalkthroughWalkthroughInjects a build-time custom user agent for Serverless Framework into AWS SDK v3 client configuration at runtime when proxy code paths are used. Applies a conditional SF_CORE_VERSION-based identifier to the client after creation; proxy and NO_PROXY logic remain unchanged. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/util/src/proxy/aws.js`:
- Around line 177-183: In addProxyToAwsClient, don’t overwrite
client.config.customUserAgent; instead merge/append the Serverless token
(customUserAgent) into the existing client.config.customUserAgent while avoiding
duplicates: detect whether client.config.customUserAgent is a string or array,
normalize to an array, push the customUserAgent only if not already present, and
set client.config.customUserAgent back to the normalized form expected by the
AWS SDK; reference the addProxyToAwsClient function, the customUserAgent
variable, and client.config.customUserAgent when making the change.
Contributor
|
Note Docstrings generation - SUCCESS |
coderabbitai bot
added a commit
that referenced
this pull request
Jan 20, 2026
Docstrings generation was requested by @czubocha. * #13279 (comment) The following files were modified: * `packages/util/src/proxy/aws.js`
Contributor
Author
|
@coderabbitai help |
Contributor
ChatThere are 3 ways to chat with CodeRabbit:
CodeRabbit commands
Other keywords and placeholders
CodeRabbit configuration file (
|
eahefnawy
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serverless-framework/<version>to the User-Agent header for all AWS SDK v3 API requestsaddProxyToAwsClient()in@serverless/utilwhich wraps all AWS clients__SF_CORE_VERSION__build-time constant for the versionExample User-Agent:
Test plan
NODE_DEBUG=httpsthatserverless-framework/4.31.0appears in all AWS API requestsSLS_AWS_SDK=3and default SDK pathspackage.jsonHow to test
Expected output should include:
Related
Closes #13245
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.