Conversation
… errors in `safeMoveFile`
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Windows CI EPERM error with retry logic
Problem
Windows CI runners fail intermittently with:
This occurs even after fixing the temp directory location because Windows can throw
EPERMtransiently due to file handle timing issues.Solution
Added EPERM retry logic in
safe-move-file.jswith exponential backoff:Total max wait: 700ms before throwing.
Safety Analysis
Verified all 3 usages of
safeMoveFileare safe for retry:resolve-ajv-validate.js: Content-addressed files (hash-based filenames)generate-zip.js: Deterministic zip from static source fileslog-deprecation.js: Idempotent text file writeChanges
packages/serverless/lib/utils/fs/safe-move-file.js: Add EPERM retry with exponential backoff