chore(deps): upgrade dotenv to v17.2.3 and remove unused loadDotEnvFile utility#13259
Merged
chore(deps): upgrade dotenv to v17.2.3 and remove unused loadDotEnvFile utility#13259
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
czubocha
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade dotenv to v17 and remove dead code
Summary
Upgrades
dotenvfrom^16.6.1to^17.2.3and removes unused dead code.Changes
Dependency Upgrade
^16.6.1→^17.2.3Breaking Change Mitigation
The only breaking change in dotenv v17.0.0 is that
quietnow defaults tofalse, causing informational runtime logs like:Added
quiet: trueto alldotenv.config()calls to suppress these logs.Dead Code Removal
Removed the unused
loadDotEnvFilefunction which was exported but never consumed:packages/sf-core/src/utils/fs/index.js(46 lines)packages/sf-core/src/utils/fs/index.jspackages/sf-core/src/utils/index.jsdotenvimport frompackages/sf-core/src/utils/fs/index.jsFiles Changed
packages/sf-core/package.jsonpackages/sf-core/src/lib/resolvers/env.jsquiet: trueto 2 callspackages/sf-core/src/utils/fs/index.jsloadDotEnvFile+ unused importpackages/sf-core/src/utils/index.jsloadDotEnvFilefrom imports/exports