Conversation
… and prettier setup
…s and remove unused dependency
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
# Conflicts: # .github/dependabot.yml # .github/workflows/release-framework.yml
eahefnawy
previously approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate to ESLint v9 Flat Config + Unified Prettier Setup
Summary
This PR migrates the monorepo to ESLint v9 with flat configuration and establishes a unified linting/formatting setup across all packages. It also adds ESLint and Prettier checks to CI.
Changes
ESLint v9 Migration
eslint.config.js— Central flat config that covers all packages.eslintrc.cjsfiles — Now using root configpackages/standards— New ESLint v9 flat config insrc/eslint.jsPrettier Unification
prettier.config.js— Re-exports frompackages/standards--ignore-pathto package scripts — Ensures consistent.prettierignoreusageCI Integration
lintjob toci-framework.yml— Runs ESLint and Prettier on every PRBug Fixes (discovered by new ESLint rules)
sf-core/src/utils/fs/index.jssf-core/src/lib/resolvers/manager.jssf-core/src/lib/runners/framework.js|| {}serverless/lib/plugins/aws/alerts/external-stack.jstypeofcheck that was always truthyserverless/lib/plugins/aws/invoke-local/index.jsimportEsmimportDead Code Removal
sf-core/src/lib/runners/cfn/aws/Bucket.jsuploadTemplate()— never called, contained bugengine/src/lib/integrations/slack.js#stage,#deleteSlackAppCredentials()— unusedsf-core/src/lib/frameworks/scf/index.js#projectConfig— unusedengine/src/lib/*/slack/apps.jscanRunOpenOnLinux()— never calledBreaking Changes
None. All changes are internal tooling, formatting, or bug fixes that improve robustness.
File Count
Testing
npm run lintpassesnpm run prettierpassesNotes
The large line diff (+1,526 / -2,628) is primarily due to:
semi: falsesetting"→'This is a one-time cleanup. Future PRs will have minimal formatting changes.