fix: use system temp dir for AJV cache to fix Windows EPERM error#13243
Merged
fix: use system temp dir for AJV cache to fix Windows EPERM error#13243
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Windows CI EPERM error in AJV schema validation cache
Problem
The Windows CI runner was failing intermittently with:
Root Cause
The
fsp.mkdtemp('sls-ajv')call in resolve-ajv-validate.js was creating temporary directories in the current working directory instead of the system temp directory.On Windows CI:
C:\a\serverless\...\sls-ajvXXX\(project workspace)C:\Users\runneradmin\.serverless\...(user home)These are in different permission zones, causing
EPERMerrors during the atomic rename operation due to permission restrictions or file handle timing issues.Solution
Changed
mkdtempto use the proper system temp directory: