Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
eahefnawy
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13240
Fix: Handle Windows path separators in AppSync schema glob patterns
Problem
On Windows, the AppSync schema resolver failed to find
.graphqlfiles when using glob patterns (e.g.,Schema/*.graphql). This resulted in emptyDefinitionin the CloudFormation template.Root Cause
globbyv10+ does not support backslash path separators. On Windows,path.join()produces paths with backslashes which caused globby to silently match zero files.Solution
Use
convertPathToPattern()from globby to convert Windows backslashes to forward slashes, andpath.posix.join()to maintain forward slashes when joining paths.Changes
Schema.js: UseconvertPathToPattern+path.posix.joinfor cross-platform path handlinggiven.js: Updated test mock to useprocess.cwd()asservicePathresolvers.test.js: Fixed mock to stripcwdprefix for portable snapshotsschema.test.js: Added test for absolute path handling