Skip to content

Comments

fix: migrate domain plugin to AWS SDK v3#13198

Merged
czubocha merged 4 commits intomainfrom
sc-3700
Jan 7, 2026
Merged

fix: migrate domain plugin to AWS SDK v3#13198
czubocha merged 4 commits intomainfrom
sc-3700

Conversation

@czubocha
Copy link
Contributor

@czubocha czubocha commented Dec 24, 2025 •
edited
Loading

Closes #13109
Closes #13178

Summary

This Pull Request updates the domain plugin to migrate from the AWS SDK v2 to AWS SDK v3. It replaces v2-specific methods with corresponding v3 client commands, updates dependency imports, and adjusts utility functions to align with the SDK v3 structure.

Main Changes:

Dependencies:

  • Added AWS SDK v3 packages (e.g., @aws-sdk/client-acm, @aws-sdk/client-api-gateway, @aws-sdk/credential-providers).
  • Removed reliance on the AWS SDK v2 package (aws-sdk).

Code Refactoring:

  • Replaced AWS SDK v2 classes (e.g., AWS.ACM) with AWS SDK v3 client instances (e.g., ACMClient).
  • Updated specific API calls (e.g., describeStackResource, listExports) to use v3 command objects (DescribeStackResourceCommand, ListExportsCommand).
  • Modified utility functions (e.g., the paginated API call method getAWSPagedResults) to work with SDK v3.

Class Changes:

  • Updated the configuration initialization for clients to handle v3 retry strategies (ConfiguredRetryStrategy) and credentials.
  • Adjusted exception handling logic (e.g., error objects contain metadata like $metadata.httpStatusCode in v3).

Globals:

  • Simplified region and credentials retrieval using v3 utilities like fromIni.
  • Ensured AWS region and profile are configured via Serverless framework options.

Removal of Legacy Code:

  • Removed legacy support for AWS SDK v2 credentials and region handling

@Mmarzex
Copy link
Contributor

Mmarzex commented Dec 24, 2025 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@czubocha czubocha requested a review from eahefnawy December 24, 2025 01:51
eahefnawy
eahefnawy previously approved these changes Dec 24, 2025
View reviewed changes
@czubocha
Merge branch 'main' into sc-3700
fa410a8 
# Conflicts:
#	package-lock.json
#	packages/serverless/package.json
@czubocha
update lockfile
7f9e5fb
@czubocha czubocha merged commit ee3f3cb into main Jan 7, 2026
10 checks passed
@czubocha czubocha deleted the sc-3700 branch January 7, 2026 17:08
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eahefnawy eahefnawy eahefnawy left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@czubocha @Mmarzex @eahefnawy