Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Pull request overview
This PR enhances AWS CloudFormation stack monitoring to fix hanging issues in verbose mode and improve error detection. It adds logic to detect DELETE_IN_PROGRESS as an error condition during create/update actions and expands terminal status checks to include CREATE_FAILED and UPDATE_FAILED.
- Adds detection of stack-level DELETE_IN_PROGRESS as an error during non-delete operations
- Expands verbose mode terminal status checks to include CREATE_FAILED and UPDATE_FAILED
- Adds comprehensive unit tests covering various stack monitoring scenarios including error cases and verbose mode behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/serverless/lib/plugins/aws/lib/monitor-stack.js | Enhanced error detection logic and expanded terminal status checks for verbose mode |
| packages/serverless/test/unit/lib/plugins/aws/lib/monitor-stack.test.js | Added comprehensive unit tests for various stack monitoring scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eahefnawy
reviewed
Dec 24, 2025
eahefnawy
previously approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12770
Closes #13181
Summary
This Pull Request enhances the monitoring logic of AWS CloudFormation stacks in the monitor-stack.js file and adds comprehensive unit tests for various stack monitoring scenarios in monitor-stack.test.js.
Main Changes: