Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Pull request overview
This PR consolidates two separate patternProperties patterns in the AWS CloudFormation Resources schema into a single pattern to work around a limitation in the json-schema-to-typescript library that prevents it from handling multiple pattern properties correctly.
Key Changes:
- Merged resource name pattern (
^[a-zA-Z0-9]{1,255}$) and Fn::ForEach macro pattern (^Fn::ForEach::[a-zA-Z0-9]+$) into one consolidated regex pattern - Wrapped both resource schemas in a
oneOfarray to maintain support for both resource types - Added inline documentation explaining the workaround
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eahefnawy
approved these changes
Dec 24, 2025
|
what exactly is this waiting on? |
czubocha
referenced
this pull request
in serverless/typescript
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13183
Summary
This Pull Request updates the AWS provider JSON schema in the Serverless framework to consolidate the handling of resource names and Fn::ForEach macros. This is done to work around a limitation in the json-schema-to-typescript library, ensuring better support for these patterns.
Main Changes:
This change is specific to improving JSON schema compatibility and does not affect runtime behavior.