Skip to content

Comments

docs: Add Dashboard docs on source maps#12220

Merged
czubocha merged 6 commits intomainfrom
docs-dashboard-source-maps
Oct 23, 2023
Merged

docs: Add Dashboard docs on source maps#12220
czubocha merged 6 commits intomainfrom
docs-dashboard-source-maps

Conversation

@skierkowski
Copy link
Member

This is a docs-only change. It adds documentation on setting up Source Maps to work with the Node.js Serverless SDK. It is a general solution, not specific to Dashboard, but required for Dashboard to properly get the stacks for captured error events.

@skierkowski skierkowski requested a review from czubocha October 18, 2023 23:59
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad8bbf1) 86.65% compared to head (3cd5a88) 86.65%.
Report is 1 commits behind head on main.

❗ Current head 3cd5a88 differs from pull request most recent head 3b36059. Consider uploading reports for the commit 3b36059 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12220   +/-   ##
=======================================
  Coverage   86.65%   86.65%           
=======================================
  Files         311      311           
  Lines       13089    13089           
=======================================
  Hits        11342    11342           
  Misses       1747     1747           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@czubocha czubocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment about the --enable-source-maps option being experimental

@skierkowski skierkowski requested a review from czubocha October 19, 2023 20:54
Co-authored-by: Tomasz Czubocha <[email protected]>
@skierkowski skierkowski marked this pull request as ready for review October 19, 2023 20:57
@skierkowski skierkowski requested a review from czubocha October 19, 2023 20:58
czubocha
czubocha previously approved these changes Oct 19, 2023
@czubocha czubocha merged commit 77a689a into main Oct 23, 2023
@czubocha czubocha deleted the docs-dashboard-source-maps branch October 23, 2023 13:45
khacminh pushed a commit to khacminh/serverless that referenced this pull request Nov 29, 2023
* docs: Add Dashboard docs on source maps

* docs: Recommend esbuild for typescript

* docs: Correction, not experimental

* docs: Add note on versioning nad disableWrapping

* docs: Fix typo

Co-authored-by: Tomasz Czubocha <[email protected]>

* docs: Change source map support SF version

---------

Co-authored-by: Tomasz Czubocha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants