Skip to content

Comments

fix: Do not use isDashboard in onboarding flow#12160

Merged
Mmarzex merged 3 commits intomainfrom
fix-dashboard-login-onboarding
Sep 16, 2023
Merged

fix: Do not use isDashboard in onboarding flow#12160
Mmarzex merged 3 commits intomainfrom
fix-dashboard-login-onboarding

Conversation

@Mmarzex
Copy link
Contributor

@Mmarzex Mmarzex commented Sep 15, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (737bc1e) 86.54% compared to head (1a2cbe3) 86.54%.

❗ Current head 1a2cbe3 differs from pull request most recent head 60c5391. Consider uploading reports for the commit 60c5391 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12160      +/-   ##
==========================================
- Coverage   86.54%   86.54%   -0.01%     
==========================================
  Files         311      311              
  Lines       13122    13116       -6     
==========================================
- Hits        11357    11351       -6     
  Misses       1765     1765              
Files Changed Coverage Δ
lib/cli/interactive-setup/dashboard-login.js 80.85% <100.00%> (-1.15%) ⬇️
lib/cli/interactive-setup/dashboard-set-org.js 94.37% <100.00%> (-0.11%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mmarzex Mmarzex merged commit 1f8d786 into main Sep 16, 2023
@Mmarzex Mmarzex deleted the fix-dashboard-login-onboarding branch September 16, 2023 02:20
khacminh pushed a commit to khacminh/serverless that referenced this pull request Nov 29, 2023
* fix: Do not use isDashboard in onboarding flow

* chore: Remove CONSOLE_CONTEXT tests from onboarding

* fix: Update interactive setup test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant