Skip to content

Comments

fix: Local credentials should be resolved in onboarding command#12148

Merged
Mmarzex merged 1 commit intomainfrom
fix-credential-regression
Sep 12, 2023
Merged

fix: Local credentials should be resolved in onboarding command#12148
Mmarzex merged 1 commit intomainfrom
fix-credential-regression

Conversation

@Mmarzex
Copy link
Contributor

@Mmarzex Mmarzex commented Sep 12, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 42.85% and project coverage change: -0.03% ⚠️

Comparison is base (bf518b9) 85.66% compared to head (83011a0) 85.64%.

❗ Current head 83011a0 differs from pull request most recent head d449930. Consider uploading reports for the commit d449930 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12148      +/-   ##
==========================================
- Coverage   85.66%   85.64%   -0.03%     
==========================================
  Files         317      317              
  Lines       13716    13723       +7     
==========================================
+ Hits        11750    11753       +3     
- Misses       1966     1970       +4     
Files Changed Coverage Δ
lib/cli/interactive-setup/aws-credentials.js 83.08% <42.85%> (-1.46%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mmarzex Mmarzex merged commit 307865d into main Sep 12, 2023
@Mmarzex Mmarzex deleted the fix-credential-regression branch September 12, 2023 20:13
khacminh pushed a commit to khacminh/serverless that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant