Skip to content

Comments

refactor: Updated aws credentials steps#12059

Closed
Danwakeem wants to merge 3 commits intomainfrom
SC-1266
Closed

refactor: Updated aws credentials steps#12059
Danwakeem wants to merge 3 commits intomainfrom
SC-1266

Conversation

@Danwakeem
Copy link
Contributor

Description

Updated the aws credentials step to ask for instrumenting a provider if we don't have one already set in the customers dashboard account

@Danwakeem Danwakeem requested a review from austencollins July 11, 2023 17:53
@Danwakeem Danwakeem self-assigned this Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (aefdfe5) 86.68% compared to head (9c76de8) 86.67%.

❗ Current head 9c76de8 differs from pull request most recent head 4ca9be6. Consider uploading reports for the commit 4ca9be6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12059      +/-   ##
==========================================
- Coverage   86.68%   86.67%   -0.01%     
==========================================
  Files         316      316              
  Lines       13529    13522       -7     
==========================================
- Hits        11727    11720       -7     
  Misses       1802     1802              
Impacted Files Coverage Δ
lib/cli/interactive-setup/aws-credentials.js 84.53% <100.00%> (-0.47%) ⬇️
lib/cli/interactive-setup/console-dev-mode-feed.js 88.88% <100.00%> (-0.08%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Danwakeem Danwakeem requested a review from Mmarzex July 11, 2023 18:12
Danwakeem added a commit that referenced this pull request Aug 11, 2023
@Danwakeem
Copy link
Contributor Author

Closing in favor of #12063

@Danwakeem Danwakeem closed this Aug 11, 2023
Mmarzex pushed a commit that referenced this pull request Sep 5, 2023
* feat: Post deploy serverless dashboard integration

* chore: Update unit test

* chore: Use pre integration endpoint

* chore: Updated async process

* chore: Added timeout on instrumentation call

* chore: Handle region configuration

* chore: Always send instruemntation

* chore: Updated instrumentation progress

* chore: Merge #12059
khacminh pushed a commit to khacminh/serverless that referenced this pull request Nov 29, 2023
* feat: Post deploy serverless dashboard integration

* chore: Update unit test

* chore: Use pre integration endpoint

* chore: Updated async process

* chore: Added timeout on instrumentation call

* chore: Handle region configuration

* chore: Always send instruemntation

* chore: Updated instrumentation progress

* chore: Merge serverless#12059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant