This repository was archived by the owner on Dec 9, 2024. It is now read-only.
adding in proper router processing #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthenw
approved these changes
Jul 24, 2018
Codecov Report
@@ Coverage Diff @@
## master #488 +/- ##
==========================================
+ Coverage 70.77% 70.84% +0.06%
==========================================
Files 37 37
Lines 2190 2195 +5
==========================================
+ Hits 1550 1555 +5
Misses 576 576
Partials 64 64
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Revert space parsing in the router package. This was not handling IP addresses when they are provided instead of a valid space name.
How did you implement it:
Revert a fix from #485
How can we verify it:
Todos:
Is this ready for review?: YES
Is it a breaking change?: YES