Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

Conversation

@mthenw
Copy link
Contributor

@mthenw mthenw commented Jun 29, 2018

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

@codecov
Copy link

codecov bot commented Jun 29, 2018

Codecov Report

Merging #475 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #475   +/-   ##
=======================================
  Coverage   70.66%   70.66%           
=======================================
  Files          35       35           
  Lines        2175     2175           
=======================================
  Hits         1537     1537           
  Misses        574      574           
  Partials       64       64
Impacted Files Coverage Δ
libkv/function.go 83.9% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dd9f87...ccad895. Read the comment docs.

@mthenw mthenw merged commit 24c3c35 into master Jun 29, 2018
@mthenw mthenw deleted the fix-nil branch June 29, 2018 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants