Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

Conversation

@rupakg
Copy link
Contributor

@rupakg rupakg commented Jun 14, 2018

What did you implement:

Update Slack invite link and meetups link

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

@rupakg rupakg requested a review from brianneisler June 14, 2018 17:46
Copy link
Contributor

@brianneisler brianneisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 14, 2018

Codecov Report

Merging #462 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #462   +/-   ##
=======================================
  Coverage   68.22%   68.22%           
=======================================
  Files          34       34           
  Lines        2112     2112           
=======================================
  Hits         1441     1441           
  Misses        611      611           
  Partials       60       60

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c65b0a...a5ec6b3. Read the comment docs.

@rupakg rupakg merged commit 6821c0a into master Jun 14, 2018
@rupakg rupakg deleted the rupakg-patch-1 branch June 14, 2018 17:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants